Test environment (npm run test:browser) behaves differently than real browser #2352
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent handler being called
aghArdeshir
requested review from
tlouisse,
gerjanvangeest,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
|
|
This PR: #2353 should fix this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to demonstrate how our tests behave differently than in the real browser. The issue is explained thoroughly here: #2351
Commenting out this line: https://github.com/ing-bank/lion/pull/2352/files#diff-7bfdd444e5650854e7536869ef3973956e89fbfc8562197c7c13f99cfb3047bfR37 makes the tests environment behave correctly as like in the normal browser.
I'm working on a real MR for fixing this issue which makes test environments more reliable.